refactor(auth): simplify authorization checks to use membership only
- Remove explicit ADMIN role checks in API handlers - Replace combined creator/member role checks with membership-only filters - Update seed data roles to reflect changed authorization logic - Add migration to insert hunt creators as members for consistent checks - Prevent removal of hunt creator as a member with new explicit check - Adjust related user role updates and queries accordingly - Upgrade dependencies including nuxt and zod for compatibility
This commit is contained in:
@@ -4,13 +4,6 @@ import prisma from '~~/lib/prisma';
|
||||
export default defineEventHandler(async (event) => {
|
||||
const user = await requireUserSession(event);
|
||||
|
||||
if (user.user.role !== 'ADMIN') {
|
||||
throw createError({
|
||||
status: 403,
|
||||
statusText: 'Not allowed!'
|
||||
});
|
||||
}
|
||||
|
||||
const { huntId } = await useValidatedParams(
|
||||
event,
|
||||
z.object({
|
||||
@@ -28,18 +21,11 @@ export default defineEventHandler(async (event) => {
|
||||
const hunt = await prisma.hunt.findUnique({
|
||||
where: {
|
||||
id: huntId,
|
||||
OR: [
|
||||
{
|
||||
creatorId: user.user.id
|
||||
},
|
||||
{
|
||||
members: {
|
||||
some: {
|
||||
memberId: user.user.id
|
||||
}
|
||||
}
|
||||
members: {
|
||||
some: {
|
||||
memberId: user.user.id
|
||||
}
|
||||
]
|
||||
}
|
||||
},
|
||||
select: {
|
||||
id: true,
|
||||
@@ -61,8 +47,7 @@ export default defineEventHandler(async (event) => {
|
||||
|
||||
const newUser = await prisma.user.findUnique({
|
||||
select: {
|
||||
id: true,
|
||||
role: true
|
||||
id: true
|
||||
},
|
||||
where: {
|
||||
id: userId,
|
||||
@@ -101,16 +86,6 @@ export default defineEventHandler(async (event) => {
|
||||
memberId: newUser.id
|
||||
}
|
||||
});
|
||||
if (newUser.role !== 'ADMIN') {
|
||||
await prisma.user.update({
|
||||
where: {
|
||||
id: newUser.id
|
||||
},
|
||||
data: {
|
||||
role: 'ADMIN'
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
return { success: true };
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user